Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump versions in lock files if present #84

Merged
merged 2 commits into from Sep 6, 2017

Conversation

rmg
Copy link
Member

@rmg rmg commented Sep 6, 2017

It is nice when the version number in package.json matches the version
numbers in package-lock.json and npm-shrinkwrap.json when they are being
used. They should be treated the same way bower.json is treated.

Resolves #83

@rmg rmg force-pushed the bump-shrinkwrap-on-release branch 2 times, most recently from d7c1a0d to fdff38d Compare September 6, 2017 19:42
lib/project.js Outdated
@@ -102,7 +118,7 @@ function Project$get(key, dflt) {
break;
}
return _.get(this.normalizedPkgJSON, key,
_.get(this.rawPkgJSON, key, dflt));
_.get(this.rawPkgJSON, key, dflt));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I heartily disklike coding styles where the indent of one line depends on the length of the function names in the previous. obviously, not a blocking concern!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A valid concern. It creates extra diff noise when things get renamed.

I fiddled with the rules to reduce the diff, but didn't try very hard. I can take another pass to see if there's a better config value.

@sam-github
Copy link
Contributor

the version is unused, right? but it confuses people when they look at the shrinkwrap and think somehow the own-module version should be used for something? I had long conversation about that with someone, so its good to make it up-to-date.

- Update eslintrc to config new rules to match the prevailingstyle
- Remove barely used debug dependency.
- Test on node 8 instead of 7
- Remove codacy coverage reporting, update node versions
It is nice when the version number in package.json matches the version
numbers in package-lock.json and npm-shrinkwrap.json when they are being
used. They should be treated the same way bower.json is treated.

Resolves #83
@rmg rmg force-pushed the bump-shrinkwrap-on-release branch from fdff38d to 6cbcc0c Compare September 6, 2017 20:23
@rmg
Copy link
Member Author

rmg commented Sep 6, 2017

Yes, the version is unused as far as I can tell (from browsing some of the relevant npm code).

@rmg rmg merged commit a6ac3a6 into master Sep 6, 2017
@rmg rmg deleted the bump-shrinkwrap-on-release branch September 6, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants