New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate condition #77

Open
fancycode opened this Issue Sep 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@fancycode
Member

fancycode commented Sep 5, 2018

The function HeifContext::is_grid_item is checking twice for !m_is_primary:

bool is_grid_item(){ return !m_is_primary && !m_is_primary && !m_is_alpha_channel && !m_is_depth_channel; };

Can the duplicated check simply be removed, or should it check for something else?

This was found by Coverity Scan.

farindk added a commit that referenced this issue Sep 5, 2018

@farindk

This comment has been minimized.

Show comment
Hide comment
@farindk

farindk Sep 5, 2018

Contributor

Sure. While looking at this, I saw that the whole assignment of the colour profiles for grid images is not correct. I'll have to replace it with something else.

Hence, I'll leave this open as a reminder.

Contributor

farindk commented Sep 5, 2018

Sure. While looking at this, I saw that the whole assignment of the colour profiles for grid images is not correct. I'll have to replace it with something else.

Hence, I'll leave this open as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment