New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various API changes #2

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@fancycode
Member

fancycode commented Jan 5, 2018

  • All functions that can potentially fail now return a heif_error.
  • Decoding plugins can also return errors in case something fails.
  • The libde265 decoder only uses the public API.
Various API changes:
- All functions that can potentially fail now return a "heif_error".
- Decoding plugins can also return errors in case something fails.
- The libde265 decoder only uses the public API.

@fancycode fancycode requested a review from farindk Jan 5, 2018

@fancycode

This comment has been minimized.

Show comment
Hide comment
@fancycode

fancycode Jan 5, 2018

Member

I'm thinking we should even change all functions to return a heif_error, even if they just return a number like heif_context_get_number_of_images. This allows returning an error if the passed pointers are not valid.

Member

fancycode commented Jan 5, 2018

I'm thinking we should even change all functions to return a heif_error, even if they just return a number like heif_context_get_number_of_images. This allows returning an error if the passed pointers are not valid.

fancycode and others added some commits Jan 5, 2018

@fancycode

This comment has been minimized.

Show comment
Hide comment
@fancycode

fancycode Jan 5, 2018

Member

Manually rebase and merged by @farindk

Member

fancycode commented Jan 5, 2018

Manually rebase and merged by @farindk

@fancycode fancycode closed this Jan 5, 2018

@fancycode fancycode deleted the api-changes branch Jan 5, 2018

@lzzcg lzzcg referenced this pull request Jun 19, 2018

Closed

resize heic file exception #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment