New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker resources #7
Conversation
fe2b54e
to
32570a2
Compare
ff05316
to
f9747aa
Compare
@gary-kim maybe adding also FROM alpine:3.11
RUN apk add --update coturn
CMD turnserver --prod --no-tlsv1 --no-tlsv1_1\
--tls-listening-port 5349 \
--fingerprint \
--lt-cred-mech \
--use-auth-secret \
--static-auth-secret $STATIC_SECRET \
--realm $REALM \
--total-quota 100 \
--bps-capacity=50000000 \
--max-bps=50000000 \
--stale-nonce=600 \
--cert /cert.pem \
--pkey /privkey.pem \
--cipher-list “ECDHE-RSA-AES256-GCM-SHA512:DHE-RSA-AES256-GCM-SHA512:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-SHA384″ \
--no-multicast-peers
this works for me. The coturn works also as stun
|
Honestly forgot about that part. I already had coturn set up for myself so I kind of forgot that's another thing to set up. I'll get to that in a bit once I finish what I'm working on. |
e96f76e
to
079cf7e
Compare
Okay, added coturn to the setup. Let me try connecting my current setup to this turn server to make sure it works. Yeah, seems to work. |
Hi, StrukturAG had docker container for Coturn which was designed for Spreed WebRTC. Maybe we can send our updates to the base project and this could be used as the base for the Coturn container here ? Still, love to see this being Open Sourced |
@madmath03 for what does it need redis and mongodb in coturn? |
I wanted the Coturn used here to be as simple as possible since I think most people who need something more advanced are probably going to connect it to their own separate TURN server. Still, let's see what @fancycode thinks. |
@markuman Coturn supports user authentication against a local database like SQLite, Postgres, Redis, MongoDB, etc... Redis and MongoDB are not included in the docker container, it's just the drivers required to connect an external database. Even if it's not needed for use with NextCloud Talk, we wanted to make the container provide support for (almost) 100% of Coturn capabilities. |
I tried to fork this branch and build the containers in Dockerhub but I get the following error:
Should the docker-compose build be added to travis ? |
Not sure why you're having the issue. I just tried building on a fresh system and it worked fine. Need to investigate this a bit more. Log
|
build is fine for me too. |
@markuman & @gary-kim : did you both tried to build it locally or build using DockerHub ? As mentioned, I just forked the project and pulled this branch into a I'm gonna try adding the docker / docker-compose build to Travis, see if it has the same behavior as Dockerhub |
@madmath03 locally and on a vm. |
Hi @gary-kim René |
That may have been because of using the wrong flags for Coturn which is now fixed or it may be a setup issue. |
Hello @gary-kim Successfully built 004a69bccdc7 |
Sounds like you're having the same problem as @madmath03. We could just add Python explicitly just in case. |
yes, I think too.....where should I add "python" ? |
Hi, cool stuff :) I recommend these changes to your Dockerfile:
Here is my Dockerfile which successfully builds (and runs): |
Signed-off-by: Gary Kim <gary@garykim.dev>
Good idea, thanks!
Since it's just the builder and using the Alpine install would mean installing things like make, I think it'd be better to use the Debian version. |
Just noticed janus released version 10.0.0 ;) |
Thanks for your contribution, this looks good. There are a couple of things that should be changed, but that could be done in future PRs:
|
Still a work in progress.Now complete.This is the configuration I am using on my own server with some extra Janus command line flags and a separate Coturn server. I've made several calls with it and it works.