Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example and colorscheme #266

Open
fredgrott opened this issue Apr 16, 2021 · 1 comment
Open

example and colorscheme #266

fredgrott opened this issue Apr 16, 2021 · 1 comment

Comments

@fredgrott
Copy link
Contributor

I ran into something so document it here until I fix the example.

With changes in the brightness attribute, it seems we can both use brightness in material theme and material dark theme and color scheme. It has to be either color scheme or material themes. So we should leave it alone until absolutely necessary to change.

When changed to color scheme completely one has to use this to refer to brightness in Theme

brightness == Brightness.light ? ThemeData.from(colorScheme: const ColorScheme.light()) : ThemeData.from(colorScheme: const ColorScheme.dark())

I estimate we will not have to change this until say August 2021 given the progress on material design widgets integration of color scheme migration.

@aqwert
Copy link
Collaborator

aqwert commented Apr 17, 2021

Thing is, light and dark mode I feel is not the responsibility of this package as that is based on the theme. Theming on the other hand could be abstracted to a single PlatformTheme however I am concerned that the differences between material and cupertino are just too much for it to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants