You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran into something so document it here until I fix the example.
With changes in the brightness attribute, it seems we can both use brightness in material theme and material dark theme and color scheme. It has to be either color scheme or material themes. So we should leave it alone until absolutely necessary to change.
When changed to color scheme completely one has to use this to refer to brightness in Theme
Thing is, light and dark mode I feel is not the responsibility of this package as that is based on the theme. Theming on the other hand could be abstracted to a single PlatformTheme however I am concerned that the differences between material and cupertino are just too much for it to be useful.
I ran into something so document it here until I fix the example.
With changes in the brightness attribute, it seems we can both use brightness in material theme and material dark theme and color scheme. It has to be either color scheme or material themes. So we should leave it alone until absolutely necessary to change.
When changed to color scheme completely one has to use this to refer to brightness in Theme
brightness == Brightness.light ? ThemeData.from(colorScheme: const ColorScheme.light()) : ThemeData.from(colorScheme: const ColorScheme.dark())
I estimate we will not have to change this until say August 2021 given the progress on material design widgets integration of color scheme migration.
The text was updated successfully, but these errors were encountered: