New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align categories of mutators (#11) #13

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@hugo-vrijswijk
Contributor

hugo-vrijswijk commented Dec 4, 2018

Closes #11

Renamed Array declarator literal to Array Declaration. Method Expression is set to unsupported for Stryker.NET, but it does support LINQ mutators, so we might want to change it, @richardwerkman ?

I've also ordered the categories alphabetically

Align categories of mutators
Fixes #11 

Renamed `Array declarator literal` to `Array Declaration`. `Method Expression` is set to unsupported for Stryker.NET, but it does support LINQ mutators, so we might want to change it, @richardwerkman ?

I've also ordered the categories alphabetically
@richardwerkman

This comment has been minimized.

richardwerkman commented Dec 4, 2018

We could say the Linq mutator is the language specific implementation of the Method expression mutator. That way the method expression mutator is indeed implemented for .Net. Otherwise we should add the Linq mutator seperately. But this would be unlogical since Linq is .Net specific.

@nicojs

This comment has been minimized.

Member

nicojs commented Dec 4, 2018

Merge whenever you want 👍

@hugo-vrijswijk

This comment has been minimized.

Contributor

hugo-vrijswijk commented Dec 4, 2018

Otherwise we should add the Linq mutator seperately. But this would be unlogical since Linq is .Net specific.

As the LINQ mutators are fairly similar to some that are there now I think it'd make sense to include them. I'll change them to link to each implementation

@hugo-vrijswijk

This comment has been minimized.

Contributor

hugo-vrijswijk commented Dec 4, 2018

@richardwerkman I've added the same list of LINQ mutators as in the Stryker.NET readme. If you agree we can merge I think

@richardwerkman

This comment has been minimized.

richardwerkman commented Dec 4, 2018

Yes this looks good! Merging is ok for me 👍

@hugo-vrijswijk hugo-vrijswijk merged commit 5b5eb82 into master Dec 4, 2018

@hugo-vrijswijk hugo-vrijswijk deleted the align-mutator-categories branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment