Add some advice before save-buffers-kill-emacs to avoid unnecessary prompt on exit #69

Merged
merged 1 commit into from Dec 5, 2012

2 participants

@aspiers

The recommendations on this page are pertinent - using advice is not ideal. But in this situation I don't think there is an alternative short of patching the emacs C source code.

@stsquad
Owner

Sorry I haven't merged your request yet, RL has intervened. I'll comment further once I've read up on the Advice advice you linked to.

@aspiers

No problem - I've just realised I was doing it wrong anyway. I'll force-push an updated version shortly (github should automatically update this pull request).

@stsquad
Owner

@aspiers did you ever push your update? This pull request doesn't seem to have changed.

@aspiers aspiers Add some advice before save-buffers-kill-emacs to avoid unnecessary p…
…rompt on exit

Also disable the same advice on server stop, to avoid
advice redefinition warnings on server restart.

stsquad#67
f111f12
@aspiers

Sorry - I forgot to push. I'm still not convinced this new version is 100% right, but it's better than the old one at least, and probably better than nothing too ;-)

@stsquad
Owner

I'll merge this for now so it can get wider testing. I reserve the right to revert it before the next release if people report weirdness!

@stsquad stsquad closed this Dec 5, 2012
@stsquad stsquad reopened this Dec 5, 2012
@stsquad stsquad merged commit 40ae0ff into stsquad:master Dec 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment