Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextAlign also for the table header of data grid #1357

Merged

Conversation

NoOneKnows92
Copy link
Contributor

Added the possibility to also align the table header of the data grid if wanted, which can be seen as a fix to #1000 maybe.

@NoOneKnows92 NoOneKnows92 changed the title Align also header of datagrid TextAlign also for the table header of data grid Oct 3, 2020
@stsrki
Copy link
Collaborator

stsrki commented Oct 4, 2020

I'm getting errors AlignHeader does not exist. Looking at the code I think it's not needed and probably you left it by accident?

@NoOneKnows92
Copy link
Contributor Author

I added this property to fit the current documentation where it says that the property TextAlignment only aligns the display cell and if someone wants to align the header alongside the body it needs to be set over the property AlignHeader. This would be my understanding of the current documentation and how it can be enhanced without leaving someone behind.

@stsrki
Copy link
Collaborator

stsrki commented Oct 7, 2020

Instead of using AlignHeader I have added new HeaderTextAlignment property. This way we have more freedom to align the header independently of the cell. Also, I created a new TableHeaderCellTextAlignment method so that it doesn't use the same code as in the cell.

All in all, good job and thank you :)

@stsrki stsrki merged commit 1f27efc into Megabit:dev092 Oct 7, 2020
@stsrki stsrki mentioned this pull request Oct 7, 2020
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants