Update Quick Search Docs for 1.3.0 to use new async fetchItems API #1
Conversation
|
@sttz, @SebGrenier please review |
| result | ||
| )); | ||
| } | ||
| } |
There was a problem hiding this comment.
@sttz in case you would not want at all the async version of fetchItems you could simply return null at the end of the lambda assigned to fetchItems and continue to fill the items list. Filling items works as before where items are piped synchronously.
|
Thanks! Is there a specific reason why you return null from Also, are all items first loaded asynchronously before they are displayed or would it be beneficial to return better results first so they can be shown faster? |
|
@sttz We try to yield as much as we can and as soon as possible to prevent blocking the UI. Even though it's an "async" API, it is still done on the main thread (during the application's update function). We do not wait before showing the results, so returning better results first would definitely help! Hope that helps! |
In Quick Search 1.3.0, fetchItems now need to return an IEnumerable to work with async results. I updated this quicksearch doc extension to support this new API.
Quick Search 1.3.0 should be released by the end of day (7/12/2019)