Permalink
Switch branches/tags
Nothing to show
Commits on Oct 21, 2009
  1. Reverted feature that dynamically added stylesheet

    bdukes committed Oct 21, 2009
    Dynamically adding the stylesheet didn't work in IE6, so it pretty much defeats the point of the script...
Commits on Oct 20, 2009
  1. Added logic to dynamically add the stylesheet link

    bdukes committed Oct 20, 2009
    If the `options` object has a `stylesheet` property, a link to that stylesheet will be added to the head of the document.  This prevents adding the styles for the majority of users who have an up-to-date browser (which is especially nice since the styles use a non-validating IE behavior).
  2. Refactored getting the base path for images into its own function

    bdukes committed Oct 20, 2009
    In preparation for reusing that function when dynamically adding a link to the stylesheet.
  3. Refactored and updated to idiomatic jQuery

    bdukes committed Oct 20, 2009
    Updated variable names for the callback used in `each` functions, to make it clear what each variable is.  Reused variables instead of querying for elements multiple times.  Used `hide()` instead of `display:none` and `event.preventDefault()` instead of `return false;`
  4. Fixed accidental renames

    bdukes committed Oct 20, 2009
    When renaming `jQuery` to `$`, there were a couple of places where it referred to the name of the script, rather than the `jQuery` object, and so shouldn't have been renamed.
  5. Removed `alert` with image path

    bdukes committed Oct 20, 2009
    Looks like there's a leftover debug message in here, not intended for production.
  6. Fixed broken reference

    bdukes committed Oct 20, 2009
    A reference to `this.options` was coming up as `undefined`, so I switched it to `$.pushup.options`
Commits on Oct 15, 2009
  1. Removed commented-out code

    bdukes committed Oct 15, 2009
  2. Wrapped script in immediate execution function

    bdukes committed Oct 15, 2009
    Wrapping the script in a function allows renaming the jQuery object safely, and creates a scope for all declared variables (so they stay out of the global scope).
  3. Moved immediate function invocation call into parens

    bdukes committed Oct 15, 2009
    Per JSLint, immediate function invocations should have the argument inside the wrapping parens.
  4. Changed `==` comparison to `===` to prevent unintended coercion.

    bdukes committed Oct 15, 2009
    Complies with JSLint `eqeqeq` option
  5. Considated `var` statements and made sure all variables are defined

    bdukes committed Oct 15, 2009
    Per JSLint, variables should be defined before they are used, and earch function should have only one `var` statement, at the top of the function.
  6. Moved Cookie object to the top of the file

    bdukes committed Oct 15, 2009
    To avoid issues referencing the Cookie object before it is defined (and to remove the JSLint warning), the Cookie object needs to come before the pushup code.
  7. Changed to non-coercing equality check against `' '` and `0`

    bdukes committed Oct 15, 2009
    Per JSLint, (http://www.jslint.com/lint.html#equal), checks against values that evaluate to false should be done with the non-coercing evaluator (`===` instead of `==`)
  8. Added braces to single-line block statements

    bdukes committed Oct 15, 2009
    Per JSLint (http://www.jslint.com/lint.html#required), all `if`, `while`, `for`, and `do` statments should be made with blocks to minimize errors during maintenance.
  9. Added semicolons where they were missing

    bdukes committed Oct 15, 2009
    Per JSLint (http://www.jslint.com/lint.html#semicolon), all statements should be followed by a semicolon to remove ambiguity.
Commits on Oct 11, 2009
  1. Used strict equality operator when checking against `undefined`

    bdukes committed Oct 11, 2009
    JSLint suggests to use `!==` when comparing against `undefined`, since it does not do type coercion.
  2. Updated indentation to match JSLint's "strict white space" rule

    bdukes committed Oct 11, 2009
    Made sure that each statement is on its own line.  Updated Cookie section to use a 4-space indent, like the rest of the file.
  3. Added spaces to conform to JSLint "strict white space" rule

    bdukes committed Oct 11, 2009
    Added spaces after the "function" and "if" keywords, and around "+" signs.
  4. Updated required version of Firefox to 3 and of Opera to 9.5

    bdukes committed Oct 11, 2009
    The required versions have been updated to match the main pushup project (commit aa2ed4a5 at github,com/staaky/pushup)
  5. Fixed typos in README files

    bdukes committed Oct 11, 2009
    The READMEs had a misspelling in a reference to the the resetReminder function, and misspelled the word "refactor."
Commits on Dec 21, 2008
  1. Fixing bugs with the jquery version, it now links and renders the pro…

    voodootikigod authored and stuartloxton committed Sep 3, 2008
    …per image in the right browsers.
    
    Signed-off-by: Stuart Loxton <stuart.loxton@googlemail.com>
Commits on Aug 3, 2008
Commits on Jul 31, 2008
  1. Trying to fix git[]

    stuartloxton committed Jul 31, 2008
  2. Better textile formatting on readme

    Stuart Loxton Stuart Loxton
    Stuart Loxton authored and Stuart Loxton committed Jul 31, 2008
  3. Addd README.textile for Github + README.html for anyone who downloads

    Stuart Loxton Stuart Loxton
    Stuart Loxton authored and Stuart Loxton committed Jul 31, 2008
  4. Renamed functions to match original pushup, removed required paramete…

    Stuart Loxton Stuart Loxton
    Stuart Loxton authored and Stuart Loxton committed Jul 31, 2008
    …r for show() [previously showMessage()]