Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ignore auto-repeated key presses #2

merged 1 commit into from Sep 27, 2012


None yet
2 participants

s4y commented Sep 27, 2012

If I hold down a key, the keydown event repeats and the note plays many times at once.

This works around the browser’s behavior by keeping track of which keys are down and only firing one callback per key until the key is released.


stuartmemo commented Sep 27, 2012

Awesome fix, thanks so much for this. Great username btw!

@stuartmemo stuartmemo added a commit that referenced this pull request Sep 27, 2012

@stuartmemo stuartmemo Merge pull request #2 from Sidnicious/patch-repeating-keys
Ignore auto-repeated key presses

@stuartmemo stuartmemo merged commit 6bca917 into stuartmemo:master Sep 27, 2012


s4y commented Sep 27, 2012


Though, I have mixed feelings about it. Holding down a key (pre-this-fix) and letting the oscillators build up for a few minutes make some AMAZING NOISES.


stuartmemo commented Sep 27, 2012

Haha, I know! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment