Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

.pop module doesn't look right, fix it #137

Merged
merged 1 commit into from

2 participants

@seanjsong

.pop module doesn't look right. I tried chromium 20 and firefox 16. When I open mod_doc.html, the two pops look like this:

/---------------\
|             |
|             |
|-------------/
\

My patch might be a little tricky, but luckily it only affects .pop and nothing else.

@stubbornella

Looks good, thanks!

@stubbornella stubbornella merged commit 6d0094c into stubbornella:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 10, 2012
  1. @seanjsong
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 4 deletions.
  1. +5 −4 core/module/mod.css
View
9 core/module/mod.css
@@ -26,8 +26,9 @@ b.top, b.top b, b.bottom, b.bottom b{display:block;background-repeat:no-repeat;f
.complex .top{height:5px;}
.complex .bottom{height:5px;/*margin-top:-10px;*/}
/* pop */
-.pop{overflow:visible;margin: 10px 20px 20px 10px; background-position:left top;}
-.pop .inner{right:-10px; bottom:-10px; background-position:right bottom;padding:0 10px 10px 0;}
+.pop{overflow:visible;margin: 10px 20px 20px 10px; background-position:left top; padding-top:1px;/*padding to avoid margin collapsing*/}
+.pop .inner{right:-10px; bottom:-10px; margin:9px -10px -10px 10px; background-position:right bottom;padding:0 10px 10px 0;}
.pop .tl, .pop .br{display:none;}
-.pop .bl{bottom:-10px;}
-.pop .tr{float:right;margin-right:-10px;_display:inline; /*fix double margin bug*/ }
+.pop .bottom{height:0;}
+.pop .bl{float:none;}
+.pop .tr{float:right;margin-right:-10px;margin-top:-1px;/*corresponding to padding*/_display:inline;/*fix double margin bug*/ }
Something went wrong with that request. Please try again.