Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Tardy records for CSV rows with both absence and tardy bits set #1925

Closed
kevinrobinson opened this issue Jul 21, 2018 · 1 comment
Closed
Labels

Comments

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Jul 21, 2018

Fan out in cases where both flags are set (ie, Aspen represents what's happening on that day, not a list of events).

In other words, matching_insights_record_for_row (https://github.com/studentinsights/studentinsights/blob/master/app/importers/file_importers/attendance_importer.rb#L146) can fan out to two records, not just one. attendance_event_class needs to be updated as well.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Oct 3, 2019

Done in #2658!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.