Fix bug with looking up Homeroom when ambiguous param given #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
selfie |
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
educators
What problem does this PR fix?
When linking to a homeroom by id (eg, from the profile page), the page doesn't load. This is because the lookup process with
Homeroom.friendly.find(id_or_slug)doesn't match as expected with the string version of an id. As a guess, it looks first on the name field and so if any homeroom name matches the string version of an id, it will match that first rather than matching by id. Alternately, perhaps it's doing a stricter lookup thanHomeroom.findand failing to match on a string version of the id, the way that#findwould.What does this PR do?
Fixes it by making explicit the lookup order, and removing the use of
friendlyto make queries.