Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordSyncer: Notify on changes outside expected norms #2213

Merged
merged 6 commits into from Oct 29, 2018

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Oct 29, 2018

Who is this PR for?

developers

What problem does this PR fix?

We collect stats on what happens in each call to RecordSyncer and log data on this, but if there are unexpected outcomes we aren't proactively alerted.

What does this PR do?

Adds basic alerting through Rollbar if changes are above an absolute and percentage threshold. Adds integration tests, and also adds guardrails to help ensure proper RecordSyncer usage.

Also updates BehaviorImporter to fix improper re-use of importer and syncer during spec, factor out reset_counters! and isolate specs.

Checklists

  • Core

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Oct 29, 2018

selfie

Loading

@kevinrobinson kevinrobinson merged commit ec18099 into master Oct 29, 2018
1 check was pending
Loading
@kevinrobinson kevinrobinson deleted the feature/notify-on-outlier-syncs branch Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant