StudentsImporter: Improve importing for house, sped liaison, counselor and update validations#2217
Merged
kevinrobinson merged 3 commits intomasterfrom Oct 29, 2018
Conversation
2 tasks
Contributor
Author
|
selfie |
kevinrobinson
deleted the
patch/validations-for-house-sped-liaison-counselor
branch
kevinrobinson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
educators, primarily in Bedford
What problem does this PR fix?
There are some special cases in Bedford around these values, and in the process of working around them, I found that there are many empty string values and no validations on these.
What does this PR do?
Before this PR, I manually patched the
Studentrecords in each district to set empty strings or "N/A" forsped_liaisonin Bedford tonil.This PR adds validations enforcing that. It also moves the parsing code for
sped_liaisonandcounselorintoPerDistrict. And it disables importingsped_liaisonfor Bedford, since these values are all set to "N/A" right now. Even though we are getting data in this field, it's not meaningful, so we effectively are not receiving this data at all and no value in importing it.Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?