Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StudentsImporter: Improve importing for house, sped liaison, counselor and update validations #2217



Copy link

@kevinrobinson kevinrobinson commented Oct 29, 2018

Who is this PR for?

educators, primarily in Bedford

What problem does this PR fix?

There are some special cases in Bedford around these values, and in the process of working around them, I found that there are many empty string values and no validations on these.

What does this PR do?

Before this PR, I manually patched the Student records in each district to set empty strings or "N/A" for sped_liaison in Bedford to nil.

This PR adds validations enforcing that. It also moves the parsing code for sped_liaison and counselor into PerDistrict. And it disables importing sped_liaison for Bedford, since these values are all set to "N/A" right now. Even though we are getting data in this field, it's not meaningful, so we effectively are not receiving this data at all and no value in importing it.


Which features or pages does this PR touch?

  • Core

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson kevinrobinson mentioned this pull request Oct 29, 2018
2 of 2 tasks complete
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Oct 29, 2018


@kevinrobinson kevinrobinson merged commit b7b5fb5 into master Oct 29, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
@kevinrobinson kevinrobinson deleted the patch/validations-for-house-sped-liaison-counselor branch Oct 29, 2018
@kevinrobinson kevinrobinson changed the title StudentsImporter: Improve improting for house, sped liaison, counselor and update validations StudentsImporter: Improve importing for house, sped liaison, counselor and update validations Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant