New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssessmentImporter: Update MCAS for Bedford #2223

Merged
merged 9 commits into from Oct 30, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Contributor

kevinrobinson commented Oct 30, 2018

Who is this PR for?

Bedford educators

What problem does this PR fix?

Folks in Bedford want to import MCAS assessment data, but the format of their export is different than Somerville's, so we can't just turn this on.

What does this PR do?

Makes the MCAS import process work differently using PerDistrict:

  1. Update the X2AssessmentImporter to parse different things within the same file with PerDistrict#choose_assessment_importer_row_class.
  2. Update the McasRow class to be more explicit about matching, factors out differences across districts into PerDistrict#normalized_subject_from_mcas_export.

Some other related cleanup:
3. Removes sanitization of assessment_growth currently applied across all assessments, since it conflicts with Bedford MCAS data. For now this is just removed so the only guard is database type constraint (there are no validations).
4. Removes :assessment_date as a field handled by CsvRowCleaner, and push this out to individual importers (eg, DibelsRow and AccessRow). This is aiming to remove that class altogether to make importers more explicit about any transformations.

Checklists

Which features or pages does this PR touch?

  • Profile
  • Overview
  • X2AssessmentImporter

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@kevinrobinson

This comment has been minimized.

Contributor

kevinrobinson commented Oct 30, 2018

hmm, got what looks like a flaky test error: https://travis-ci.org/studentinsights/studentinsights/builds/448425967?utm_source=github_status&utm_medium=notification, going to restart it for now and ignore

@kevinrobinson

This comment has been minimized.

Contributor

kevinrobinson commented Oct 30, 2018

selfie

@kevinrobinson kevinrobinson merged commit 7487efe into master Oct 30, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the feature/bedford-mcas-import branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment