AssessmentImporter: Update MCAS for Bedford#2223
Merged
kevinrobinson merged 9 commits intomasterfrom Oct 30, 2018
Merged
Conversation
Contributor
Author
|
hmm, got what looks like a flaky test error: https://travis-ci.org/studentinsights/studentinsights/builds/448425967?utm_source=github_status&utm_medium=notification, going to restart it for now and ignore |
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
Bedford educators
What problem does this PR fix?
Folks in Bedford want to import MCAS assessment data, but the format of their export is different than Somerville's, so we can't just turn this on.
What does this PR do?
Makes the MCAS import process work differently using
PerDistrict:X2AssessmentImporterto parse different things within the same file withPerDistrict#choose_assessment_importer_row_class.McasRowclass to be more explicit about matching, factors out differences across districts intoPerDistrict#normalized_subject_from_mcas_export.Some other related cleanup:
3. Removes sanitization of
assessment_growthcurrently applied across all assessments, since it conflicts with Bedford MCAS data. For now this is just removed so the only guard is database type constraint (there are no validations).4. Removes
:assessment_dateas a field handled byCsvRowCleaner, and push this out to individual importers (eg,DibelsRowandAccessRow). This is aiming to remove that class altogether to make importers more explicit about any transformations.Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?