New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with MCAS score range for E, move into helpers #2226

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Contributor

kevinrobinson commented Nov 1, 2018

Who is this PR for?

school admin

What problem does this PR fix?

The school overview page filters have a bug that prevents "E" scores from being filterable for next gen MCAS. This came up testing new MCAS data for Bedford.

What does this PR do?

Fixes the bug; factors out these definitions into mcasScores and moves that into helpers.

Screenshot (if adding a client-side feature)

the bug:
Uploading Screen Shot 2018-11-01 at 3.21.01 PM.png…

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • School Overview

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes

kevinrobinson added some commits Nov 1, 2018

@kevinrobinson

This comment has been minimized.

Contributor

kevinrobinson commented Nov 1, 2018

selfie

@kevinrobinson kevinrobinson merged commit a73caf5 into master Nov 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/mcas-scores-ranges branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment