New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Fix bug in showing SGP data for Next Gen MCAS #2228

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Contributor

kevinrobinson commented Nov 1, 2018

Who is this PR for?

educators, 3-12

What problem does this PR fix?

The charts for SGP only show data for old MCAS, not Next Gen MCAS.

What does this PR do?

Includes both tests.

Checklists

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here

@kevinrobinson kevinrobinson force-pushed the patch/profile-chart-data-growth branch from 7e21628 to d311fd0 Nov 1, 2018

@kevinrobinson

This comment has been minimized.

Contributor

kevinrobinson commented Nov 1, 2018

selfie

@kevinrobinson kevinrobinson merged commit 2e1c5cc into master Nov 1, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the patch/profile-chart-data-growth branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment