Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Counselor meeting note type for Somerville, fix bug that allowed trying to save … #2233

merged 4 commits into from Nov 5, 2018


Copy link

@kevinrobinson kevinrobinson commented Nov 5, 2018

…note when no text

Who is this PR for?

HS counselors in Somerville

What problem does this PR fix?

Counselors want to have their own note type, to be able to search on later, or to find gaps in service.

What does this PR do?

Adds a new note type, updates some UI elements to use this.

It also fixes an unrelated UI bug that allowed users to try to save a note that had no text (the server would correctly reject the change).

Screenshot (if adding a client-side feature)

screen shot 2018-11-02 at 1 41 32 pm

screen shot 2018-11-05 at 11 46 45 am

screen shot 2018-11-02 at 1 53 42 pm

screen shot 2018-11-02 at 1 53 35 pm

screen shot 2018-11-02 at 1 53 23 pm

screen shot 2018-11-02 at 1 53 18 pm


Which features or pages does this PR touch?

  • Home page
  • Student Profile
  • Homeroom
  • Section
  • School Overview
  • Absences
  • Tardies
  • Discipline
  • Levels

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

Copy link
Contributor Author

I also already added the new EventNoteType manually.

Copy link
Contributor Author


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant