New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Allow showing MCAS in summary if no STAR, remove SGP graphs if no data #2234

Merged
merged 3 commits into from Nov 5, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 5, 2018

Who is this PR for?

Bedford educators

What problem does this PR fix?

In Bedford, they don't use STAR assessments, but the profile still assumes these are meaningful.

Separately, there's no SGP data for students in younger grades (or other students taking MCAS for the first time). Yet these charts still appear.

What does this PR do?

Adds a PerDistrict.js function that enables showing MCAS in place of STAR for the summary tabs on the student profile.

Updates the details sections to hide the SGP charts if there is no data.

Screenshot (if adding a client-side feature)

screen shot 2018-11-05 at 12 31 48 pm

screen shot 2018-11-05 at 12 33 54 pm

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Nov 5, 2018

selfie

@kevinrobinson kevinrobinson merged commit 0009286 into master Nov 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/remove-sgp-if-no-data branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment