Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levels: Improve matching for ESL SS course #2235

Merged
merged 4 commits into from Nov 5, 2018

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Nov 5, 2018

Who is this PR for?

HS educators, HS English learners

What problem does this PR fix?

The matching of course to "subject" doesn't match "ESL - Semester SS" correctly.

What does this PR do?

Fixes it.

Checklists

Which features or pages does this PR touch?

  • Levels

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Nov 5, 2018

selfie

@kevinrobinson kevinrobinson merged commit 2bd2dff into master Nov 5, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/ell-courses-matching branch Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant