New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with sending null valued SGP to UI #2239

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 6, 2018

Who is this PR for?

Bedford educators

What problem does this PR fix?

Bedford doesn't have SGP data, but these charts still appear on the profile page. This is from the server sending down data points that have null, when it should be filtering these out.

What does this PR do?

Filters these values out; same for scale score.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Nov 6, 2018

selfie

@kevinrobinson kevinrobinson merged commit f752246 into master Nov 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/filter-null-sgp-for-chart branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment