Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out schools without active students on districtwide page (eg, PIC) #2246

Merged

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Nov 19, 2018

Related https://rollbar.com/somerville-teacher-tool/somerville-teacher-tool/items/267/?item_page=0&item_count=100&#traceback

Who is this PR for?

districtwide educators

What problem does this PR fix?

Certain school codes that serve only administrative purposes can appear on the districtwide admin page, but they have no students when folks click in.

What does this PR do?

Removes those schools.

Checklists

Which features or pages does this PR touch?

  • Districtwide admin page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Nov 20, 2018

selfie

@kevinrobinson kevinrobinson merged commit 4699868 into master Nov 20, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the patch/filter-district-schools-with-no-students branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant