New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging download filenames via send_data #2268

Merged
merged 3 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 26, 2018

Who is this PR for?

students, families

What problem does this PR fix?

Rails' send_data method logs the filename, and these filenames contain personally identifiable information that would be stored in Logentries.

What does this PR do?

Patch Rails to remove this, update our fake Rails logger, add specs for this.

Checklists

Which features or pages does this PR touch?

  • Student Profile (IEP, profile PDF)

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@studentinsights-bot

This comment has been minimized.

Copy link

studentinsights-bot commented Nov 26, 2018

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

@kevinrobinson kevinrobinson changed the title Avoid logging download filenames Avoid logging download filenames via send_data Nov 26, 2018

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Nov 26, 2018

selfie

@kevinrobinson kevinrobinson merged commit 2b99382 into master Nov 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/avoid-logging-download-filenames branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment