Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging download filenames via send_data #2268

merged 3 commits into from Nov 26, 2018


Copy link

@kevinrobinson kevinrobinson commented Nov 26, 2018

Who is this PR for?

students, families

What problem does this PR fix?

Rails' send_data method logs the filename, and these filenames contain personally identifiable information that would be stored in Logentries.

What does this PR do?

Patch Rails to remove this, update our fake Rails logger, add specs for this.


Which features or pages does this PR touch?

  • Student Profile (IEP, profile PDF)

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

Copy link

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

@kevinrobinson kevinrobinson changed the title Avoid logging download filenames Avoid logging download filenames via send_data Nov 26, 2018
Copy link
Contributor Author


@kevinrobinson kevinrobinson merged commit 2b99382 into master Nov 26, 2018
@kevinrobinson kevinrobinson deleted the patch/avoid-logging-download-filenames branch November 26, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants