New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request spec verifying no unauthenticated routes #2269

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Nov 26, 2018

Who is this PR for?

students, families, developers

What does this PR do?

Adds another guard to check for unauthenticated endpoints beyond ApplicationController. Also removes unused ActionStorage endpoints.

Checklists

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@studentinsights-bot

This comment has been minimized.

Copy link

studentinsights-bot commented Nov 26, 2018

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Nov 27, 2018

selfie

@kevinrobinson kevinrobinson merged commit fcba54c into master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/whitelist-unauthenticated-routes branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment