Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable multifactor authorization flows using Authenticator app and SMS #2274
This is a replacement for #2248, since it batches in much more automated and manual testing.
Who is this PR for?
students, families, districtwide admin
What problem does this PR fix?
We don't have multifactor authentication enabled for any users yet, and it's hard to update the login flow since it's embedded in the core layout, and because changes here involve interop with Devise.
What does this PR do?
First, factors out the sign in form to its own page, outside of the navbar. This enables better isolation here, and some styling is improved and cleaned in the process.
Second, this updates the form and authentication setup in Devise and our strategy to allow an additional
Third, this adds JS to the sign in page that allows a multifactor login flow (see below). This PR does not enable this flow for any users.
Fourth, this adds server models and endpoints for two kinds of multifactor authentication flows: an using an authenticator app or SMS. The authenticator app is more secure but more friction, with the idea that it can be for developer accounts to start, while SMS could be enabled for project leads and districtwide admin. Migrating users will take a while and have to be done in phases; this PR assumes this is not enabled for anyone to start. These endpoints are protected by
Fifth, this adds more layers of tests for all files touched, including more edge cases to the authentication specs, specifically ones that test whether it guards against invalid upstream and downstream behavior. It also factors out the actual call to the LDAP server into
EDIT: This PR also includes
Screenshot (if adding a client-side feature)
Sign in styling, with "Use multifactor login" link
Multifactor sign in, step 1
Multifactor sign in, step 2
Updated invalid login message, same for all reasons, including multifactor required
Required fields warnings across browsers
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?
Deploying requires some config changes as well. To deploy, I'll deploy to demo first and do more manual testing there as well before deploying this to any production sites. The first production deployments will also omit configuration that prevent SMS authentication altogether.