New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

504: Add initial importer for Somerville, minimal UI for data quality checks #2294

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
2 participants
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Dec 8, 2018

Who is this PR for?

students, families, educators - HS counselors to start

What problem does this PR fix?

504 data isn't visible in Student Insights.

What does this PR do?

Builds on #2287 and adds an initial importer for the "ed plans" from Somerville but not yet for accommodations. Adds a minimal UI to show this when enabled by the enable_viewing_504_data_in_profile label, so we can start looking at data quality with folks, which has been a concern previously.

Screenshot (if adding a client-side feature)

screen shot 2018-12-08 at 10 53 17 am

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@studentinsights-bot

This comment has been minimized.

Copy link

studentinsights-bot commented Dec 8, 2018

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

504: Add SQL and initial importer for Somerville, minimal UI for dat…
…a quality checks

Done with FileImporterOptions, need more cleanup on tests

Done for ed plan importer

Minimal working UI for auditing data quality

Student profile updated

Add test for EdPlanPanel and snapshot for it

Add updated story

@kevinrobinson kevinrobinson force-pushed the feature/ed-plan-import branch from 02a85b6 to 62cb5ae Dec 8, 2018

@kevinrobinson kevinrobinson changed the title 504: Add SQL and initial importer for Somerville, minimal UI for data quality checks 504: Add initial importer for Somerville, minimal UI for data quality checks Dec 8, 2018

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Dec 8, 2018

selfie

@kevinrobinson kevinrobinson merged commit 5ab478a into master Dec 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/ed-plan-import branch Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment