Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up504: Update minimal review UI to include accommodations #2302
Conversation
kevinrobinson
added some commits
Dec 9, 2018
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
merged commit 78d6c44
into
master
Dec 9, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
kevinrobinson
deleted the
feature/504-review-ui
branch
Dec 9, 2018
kevinrobinson
referenced this pull request
Dec 9, 2018
Merged
Update JS parsing of last modified for 504 records #2303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevinrobinson commentedDec 9, 2018
This builds on #2301 and #2294
It update the minimal review UI so we can use it for investigating any data quality issues, and also removes server responses for users not feature switched.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?