Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

504: Update plan_504 method on student record to read EdPlan for Somerville #2315

merged 6 commits into from Dec 11, 2018


Copy link

Related to #2287.

Who is this PR for?

Somerville educators

What problem does this PR fix?

The plan_504 value coming from the SIS export isn't accurate; it overcounts students who have an ed plan set to "previous" status.

What does this PR do?

To work around this, this PR adds a method to the Student model to patch this for Somerville. We could update the student export to solve this upstream, but this is a faster change and self-contained. Aside from the complexity downside, this also means doing another query for each read of plan_504, which could be expensive for calls like with an eager include.

This also updates the JS function that decides about showing "504 plan" so that it is stricter, which isn't directly related to the server-side change (since the server-side change for Somerville keeps the same API with the UI).


Which features or pages does this PR touch?

  • Student Profile
  • School Overview

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

Copy link
Contributor Author


@kevinrobinson kevinrobinson merged commit 8772093 into master Dec 11, 2018
@kevinrobinson kevinrobinson deleted the patch/504-active-ed-plans branch December 11, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant