New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

504: Update EdPlanImporter validations, explicitly skip when 'specific disability' is missing #2322

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Dec 12, 2018

Who is this PR for?

developers

What problem does this PR fix?

The validation on 'specific disability' led to a large number of records failing (mostly for "draft" plans).

What does this PR do?

Skips these explicitly in the importer.

Checklists

Which features or pages does this PR touch?

  • Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Dec 12, 2018

selfie

@kevinrobinson kevinrobinson merged commit 0ddbc68 into master Dec 12, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the patch/ed-plan-importer-validations branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment