New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My notes: Revise layout and add word cloud, shipped dark #2325

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Dec 13, 2018

Who is this PR for?

educators

What does this PR do?

This is a prototype, but adds in a wordcloud as reflection support on my notes page, shipped dark with querystring switch.

Factors out <WordCloud /> from search page, as well as a <BoxCard /> component for the sidebar style there and on the home page (not touched here).

Screenshot (if adding a client-side feature)

Checklists

Which features or pages does this PR touch?

  • My Notes
  • Search Notes

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson kevinrobinson changed the title My notes: Revise layout, add dark word cloud, refactored from search My notes: Revise layout and add word cloud, shipped dark Dec 13, 2018

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Dec 13, 2018

selfie

@kevinrobinson kevinrobinson merged commit b3d06a4 into master Dec 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/my-notes-wordcloud branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment