New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Add teacher name for homeroom #2338

Merged
merged 3 commits into from Dec 20, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Dec 20, 2018

Who is this PR for?

all educators, came up for Bedford folks

What problem does this PR fix?

Homeroom names are sometimes cryptic, or not used in some schools, so it's not obvious what actual homeroom that refers too.

What does this PR do?

Adds in the homeroom teacher's name inline.

Updates a stale bit in schema.rb as well.

Screenshot (if adding a client-side feature)

image

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

kevinrobinson added some commits Dec 20, 2018

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Dec 20, 2018

selfie

@kevinrobinson kevinrobinson merged commit ab605f2 into master Dec 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/homeroom-teacher branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment