New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar: Used new logo #2339

Merged
merged 4 commits into from Dec 21, 2018

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Dec 20, 2018

Who is this PR for?

all users

What problem does this PR fix?

The logo on the sign in page has been updated, but the navbar when educators are signed in is still the old one.

What does this PR do?

Updates the signed in navbar to use the new logo, to match @ciscomeneses's awesome work on the sign in page in #2337.

Screenshot (if adding a client-side feature)

screen shot 2018-12-20 at 5 38 04 pm

Checklists

Which features or pages does this PR touch?

  • Core, navbar

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here

kevinrobinson added some commits Dec 20, 2018

@kevinrobinson kevinrobinson force-pushed the feature/navbar-logo branch from d3a6245 to c7f89be Dec 20, 2018

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Dec 21, 2018

I ran into problems with the layout on IE11, so pushed a commit for that, but the signed in navbar has a similar problem, so I'll need to fix that next too.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Dec 21, 2018

Pushed another commit that fixes the layout for CSS for Internet Explorer 11. As best I understand it, the problem is that IE11 sizes SVG elements differently than Firefox, Safari and Chrome, and differently than the way it would plain HTML elements.

There's still a small alignment issue on IE11 on the sign in page that I can't figure out without breaking the other browsers, so I'm going to ship this so the new logos are out for everyone on both the sign in and signed-in pages, and then I can try to tweak the IE11 problem separately after.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Dec 21, 2018

🚢 ing this (cc @ciscomeneses)

@kevinrobinson kevinrobinson merged commit bfd0031 into master Dec 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/navbar-logo branch Dec 21, 2018

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Dec 21, 2018

This is deployed now, and looks great! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment