Skip to content

Teams: Updates to show teams over multiple seasons #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 8, 2019

Conversation

kevinrobinson
Copy link
Contributor

Follow-on to #2345

Who is this PR for?

HS educators, students and coaches

What problem does this PR fix?

Allowing storing and showing multiple sports teams - from the current season and past seasons.

What does this PR do?

Update dev setup for teams to be tied to test time, updates the server code to serialize data about years and whether the season is active (Somerville-only), and updates the UI to show more context on whether it's a sport in the current season or past.

Screenshot (if adding a client-side feature)

image
image

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage

@kevinrobinson
Copy link
Contributor Author

selfie

@kevinrobinson kevinrobinson merged commit 6fb9eb4 into master Jan 8, 2019
@kevinrobinson kevinrobinson deleted the feature/teams-with-seasons branch January 8, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant