Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Minimal prototype for grouping workflow, no computation, interaction or persistence #2360

Merged
merged 6 commits into from Jan 18, 2019

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Jan 18, 2019

Who is this PR for?

K5 reading teams

What problem does this PR fix?

Supporting reading teams in using benchmark reading data in reviewing and revising instructional groupings.

What does this PR do?

Adds a new grouping read page, shipped dark and behind a feature switch.

Screenshot (if adding a client-side feature)

screen shot 2019-01-18 at 1 02 06 pm

screen shot 2019-01-18 at 1 02 38 pm

screen shot 2019-01-18 at 1 02 46 pm

Checklists

Which features or pages does this PR touch?

  • Reading groups page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@studentinsights-bot
Copy link

@studentinsights-bot studentinsights-bot commented Jan 18, 2019

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jan 18, 2019

selfie

@kevinrobinson kevinrobinson merged commit 66cd4a5 into master Jan 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinrobinson kevinrobinson deleted the feature/reading-grouping-prototype branch Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants