Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Update grouping page to include computations, cut points, and click to see more #2363



Copy link

@kevinrobinson kevinrobinson commented Jan 22, 2019

Who is this PR for?

K5 reading teams

What problem does this PR fix?

Builds forward on the work in #2360, enabling K5 reading teams to make use of benchmark reading data and data from other sources within A&R and instructional planning meetings.

What does this PR do?

Makes some improvements in navigation, but focuses mostly on the core grouping UX. This includes revising styling, adding in computations for reading groups, and enabling the "click to see more inline" interaction for an individual student.

One difference from previous mocks is that the "mentioned in notes" bit is cut here since it involves pushing that keyword-based search to the server to limit the notes shared across the whole team.

Note that most of this code is not generalized to all teams, grades, or reading benchmark assessments yet; the intention is still to pilot this tomorrow and then decide on the next iteration forward (either further revisions, or work towards generalizing for next pilot teams).

Screenshot (if adding a client-side feature)

screen shot 2019-01-22 at 1 43 26 pm


Which features or pages does this PR touch?

  • Reading entry page
  • Reading groups page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jan 22, 2019


@kevinrobinson kevinrobinson merged commit f88ea90 into master Jan 22, 2019
1 check passed
@kevinrobinson kevinrobinson deleted the feature/reading-grouping-calculation-interactions branch Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant