New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discipline code back to filter #2365

Merged
merged 3 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@edavidsonsawyer
Copy link
Collaborator

edavidsonsawyer commented Jan 22, 2019

Who is this PR for?

Educators

What problem does this PR fix?

Schools have many different codes for discipline incidents, but there is no easy way to see how many of each type they have across the school.

What does this PR do?

Adds an option to the discipline dashboard to view discipline incidents broken down by code.

Screenshot (if adding a client-side feature)

incident_codes

Checklists

Which features or pages does this PR touch?

  • Discipline

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here
@edavidsonsawyer

This comment has been minimized.

Copy link
Collaborator Author

edavidsonsawyer commented Jan 22, 2019

@kevinrobinson I forgot about this! It's a quick change that we can put in whenever it's wanted.

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Jan 22, 2019

@edavidsonsawyer Awesome! ⚡️

When you get a chance, can you also rename the filter to "Incident code" instead of "Incident type" too? I think that's my mistake from before, the label you added here made me think of it and folks will see "code" within Aspen too. Thanks!

@edavidsonsawyer

This comment has been minimized.

Copy link
Collaborator Author

edavidsonsawyer commented Jan 23, 2019

@kevinrobinson my bad! I meant to change that be in sync with the other language anyway. Should be all set now!

@kevinrobinson

This comment has been minimized.

Copy link
Contributor

kevinrobinson commented Jan 23, 2019

@edavidsonsawyer no worries, thanks for improving it! 👍

@kevinrobinson kevinrobinson merged commit 88c0f2e into studentinsights:master Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment