Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise timing for SessionRenewal to actually enable renewing #2366

Merged
merged 1 commit into from Jan 22, 2019

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Jan 22, 2019

Who is this PR for?

educators, particularly folks facilitating MTSS or longer discussions

What problem does this PR fix?

SessionRenewal uses a rough heuristic to warn users if their session is about to expire. But there's a bug at the call site that means it only shows the warning for one second before forcing a reload. This can lead to folks actively working with a page open for a long time to lose their work (eg, taking notes on the profile page during a long MTSS meeting, and the page just reloads without saving or warning).

What does this PR do?

Sets the warning to show for 60 seconds. Longer term we should revisit this altogether, but this improves things immediately today.

Checklists

Which features or pages does this PR touch?

  • Core UI

Does this PR use tests to help verify we can deploy these changes quickly and confidently?
ed of better test coverage

  • Manual testing made more sense here
@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Jan 22, 2019

selfie

@kevinrobinson kevinrobinson merged commit b2a6c8c into master Jan 22, 2019
1 check passed
@kevinrobinson kevinrobinson deleted the patch/revise-session-timeout-warning branch Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant