Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRevise timing for SessionRenewal to actually enable renewing #2366
Conversation
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
merged commit b2a6c8c
into
master
Jan 22, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
kevinrobinson
deleted the
patch/revise-session-timeout-warning
branch
Jan 22, 2019
This was referenced Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevinrobinson commentedJan 22, 2019
Who is this PR for?
educators, particularly folks facilitating MTSS or longer discussions
What problem does this PR fix?
SessionRenewaluses a rough heuristic to warn users if their session is about to expire. But there's a bug at the call site that means it only shows the warning for one second before forcing a reload. This can lead to folks actively working with a page open for a long time to lose their work (eg, taking notes on the profile page during a long MTSS meeting, and the page just reloads without saving or warning).What does this PR do?
Sets the warning to show for 60 seconds. Longer term we should revisit this altogether, but this improves things immediately today.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?
ed of better test coverage