New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Iterations on grouping UI styling and feel #2367

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 22, 2019

Who is this PR for?

K5 reading teams, building on #2363

What does this PR do?

Revises UI for layout, styling, colors, etc. Also zooms in on photos, fixes layout when missing photos.

This also updates the z-index for the dialogs, which is just hacked in for now.

Screenshot (if adding a client-side feature)

coloring on sidebar, rearranging where MTSS shows:

screen shot 2019-01-22 at 4 50 24 pm

revising F&P chart style and coloring, flipping DibelsBreakdownBar

image

fixing overflow and scroll for instructional needs

image

Checklists

Which features or pages does this PR touch?

  • Reading groups page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson kevinrobinson changed the title Reading: Iterations on grouping UI and feels Reading: Iterations on grouping UI styling and feel Jan 22, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 22, 2019

selfie

@kevinrobinson kevinrobinson merged commit 4908bbb into master Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/reading-grouping-revisions branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment