New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: store grouping state locally, snapshot grouping state and post to server #2368

Merged
merged 7 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 23, 2019

Builds on #2367

Who is this PR for?

K5 reading teams

What does this PR do?

This adds the "additional groups" grouping UI, and lifts state of groupings up to maintain it across navigating between groups. It adds an Autosaver components that tracks changes and autosaves posting to the server to store that work in the database. The schema is minimal and not intended as final; this is just enabling saving during the first pilot (and not yet even reading these into the UI yet).

Screenshot (if adding a client-side feature)

(no visual feedback)

Checklists

Which features or pages does this PR touch?

  • Reading grouping page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@studentinsights-bot

This comment has been minimized.

Copy link

studentinsights-bot commented Jan 23, 2019

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

@kevinrobinson kevinrobinson changed the title Reading: snapshot groupings and post to server Reading: store grouping state locally, snapshot grouping state and post to server Jan 23, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 23, 2019

selfie

@kevinrobinson kevinrobinson merged commit 1737bb6 into master Jan 23, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the feature/reading-persistence branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment