New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted notes: Clarify that admin can also mark notes restricted #2371

Merged
merged 2 commits into from Jan 25, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 25, 2019

Who is this PR for?

educators

What problem does this PR fix?

The UI suggests that the original author of the note marked it restricted. With an initial limited release of #2243 and #2304, admin can do this as well, so the text is misleading.

What does this PR do?

Just adds copy clarifying. Before a general release later, it'd be better to make explicit who marked the note as restricted (so folks know who to follow up with), but this is a good first step for now.

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • My notes

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes

@kevinrobinson kevinrobinson force-pushed the patch/restricted-note-or-admin branch from aa571de to 21c4234 Jan 25, 2019

@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 25, 2019

selfie

@kevinrobinson kevinrobinson merged commit 14ae9cf into master Jan 25, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the patch/restricted-note-or-admin branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment