Restricted notes: Clarify that admin can also mark notes restricted#2371
Merged
kevinrobinson merged 2 commits intomasterfrom Jan 25, 2019
Merged
Restricted notes: Clarify that admin can also mark notes restricted#2371kevinrobinson merged 2 commits intomasterfrom
kevinrobinson merged 2 commits intomasterfrom
Conversation
kevinrobinson
force-pushed
the
patch/restricted-note-or-admin
branch
from
aa571de to
21c4234
Compare
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
educators
What problem does this PR fix?
The UI suggests that the original author of the note marked it restricted. With an initial limited release of #2243 and #2304, admin can do this as well, so the text is misleading.
What does this PR do?
Just adds copy clarifying. Before a general release later, it'd be better to make explicit who marked the note as restricted (so folks know who to follow up with), but this is a good first step for now.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?