Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRestricted notes: Clarify that admin can also mark notes restricted #2371
Conversation
kevinrobinson
added some commits
Jan 25, 2019
kevinrobinson
force-pushed the
patch/restricted-note-or-admin
branch
from
aa571de
to
21c4234
Jan 25, 2019
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
merged commit 14ae9cf
into
master
Jan 25, 2019
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
kevinrobinson
deleted the
patch/restricted-note-or-admin
branch
Jan 25, 2019
kevinrobinson
referenced this pull request
Jan 25, 2019
Merged
Update snapshot for My Notes about restricted note copy #2372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevinrobinson commentedJan 25, 2019
Who is this PR for?
educators
What problem does this PR fix?
The UI suggests that the original author of the note marked it restricted. With an initial limited release of #2243 and #2304, admin can do this as well, so the text is misleading.
What does this PR do?
Just adds copy clarifying. Before a general release later, it'd be better to make explicit who marked the note as restricted (so folks know who to follow up with), but this is a good first step for now.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?