Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict student discipline scatter plot to school year #2373



Copy link

@edavidsonsawyer edavidsonsawyer commented Jan 28, 2019

Who is this PR for?


What problem does this PR fix?

The student profile has a discipline incident heatmap that includes incidents for the previous school year, which is unlikely to be useful in finding patterns in the student's behavior.

What does this PR do?

Restricts the heatmap in the profile to the current school year only.


Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
Copy link

@kevinrobinson kevinrobinson commented Jan 28, 2019

@edavidsonsawyer Awesome! I had a question about the snapshot, but this seems great and I can ship it later today. 👍

Copy link

@kevinrobinson kevinrobinson left a comment

ah sorry looks like this comment didn't go through. going to ship now, but to confirm, this removes the snapshot?

it('snapshots', () => {
Copy link

@kevinrobinson kevinrobinson Jan 29, 2019

this removes the snapshot?

@kevinrobinson kevinrobinson merged commit 7ec0b0f into studentinsights:master Jan 29, 2019
1 check passed
kevinrobinson added a commit that referenced this issue Jan 29, 2019

Profile: Restrict student discipline scatter plot to school year (v2) #2373
Copy link

@kevinrobinson kevinrobinson commented Jan 29, 2019

@edavidsonsawyer I added the snapshot back in #2378 to :ship now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants