Restrict student discipline scatter plot to school year#2373
Merged
kevinrobinson merged 4 commits intostudentinsights:masterfrom Jan 29, 2019
Merged
Restrict student discipline scatter plot to school year#2373kevinrobinson merged 4 commits intostudentinsights:masterfrom
kevinrobinson merged 4 commits intostudentinsights:masterfrom
Conversation
Contributor
|
@edavidsonsawyer Awesome! I had a question about the snapshot, but this seems great and I can ship it later today. 👍 |
Contributor
kevinrobinson
left a comment
kevinrobinson
left a comment
There was a problem hiding this comment.
ah sorry looks like this comment didn't go through. going to ship now, but to confirm, this removes the snapshot?
|
|
||
| jest.mock('../components/HighchartsWrapper', () => 'highcharts-wrapper'); | ||
|
|
||
| it('snapshots', () => { |
Contributor
There was a problem hiding this comment.
this removes the snapshot?
kevinrobinson
added a commit
that referenced
this pull request
Jan 29, 2019
…snapshot Profile: Restrict student discipline scatter plot to school year (v2) #2373
Contributor
|
@edavidsonsawyer I added the snapshot back in #2378 to :ship now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
Educators
What problem does this PR fix?
The student profile has a discipline incident heatmap that includes incidents for the previous school year, which is unlikely to be useful in finding patterns in the student's behavior.
What does this PR do?
Restricts the heatmap in the profile to the current school year only.
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?