Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Discipline Dashboard release #2374
Who is this PR for?
What problem does this PR fix?
The discipline dashboard is available in production, but there are no live links to the feature.
What does this PR do?
Adds links to the discipline dashboard alongside the tardies/absences dashboards
Screenshot (if adding a client-side feature)
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?
@edavidsonsawyer Awesome! This looks good, and can we remove the experimental banner too when this is ready to go out? The other wrinkle here is that some users have additional links on the navbar - you can sign in as the
re: SHS loading, I think the issue is the n+1 where it queries for all students, then for each one queries for discipline incidents. The absences page batches these queries up and might be a model to check out: https://github.com/studentinsights/studentinsights/blob/master/app/lib/dashboard_queries.rb#L8. If there are ways to make smaller changes that'd be great to try, but just using the same approach as the absences page is fine too, which might be easier without profiling.
@kevinrobinson thanks for flagging the users with extra links. I tested with both of them at a bunch of resolutions and everything seems to fit. One note is that I don't think the Jodi user is supposed to have access to the dashboards (she doesn't now). Is that not correct?