Removing n+1 queries in discipline dashboard#2375
Merged
kevinrobinson merged 3 commits intoJan 29, 2019
Merged
Conversation
Collaborator
Author
|
@kevinrobinson frankly I thought this had been done way back when the discipline stuff first went out. Oversight on my part. Locally this improved load times quite a bit, but it would be good to see how big a difference it makes in production. |
Collaborator
Author
|
@kevinrobinson hold off on this. There seems to be a bug with how this handles event notes. It's actually affecting the absence dashboard as well right now (which makes sense) |
Collaborator
Author
|
@kevinrobinson Nevermind all that. It turns out I just didn't have any event_notes for my users that were less than a year old. This is all working as expected! |
Collaborator
Author
|
@kevinrobinson okay, now this should be all set to go when you're ready. |
Contributor
|
@edavidsonsawyer awesome! 👍 Tested this and it looks great, 🚢 ing to confirm now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
educators
What problem does this PR fix?
Discipline data loads slowly as a result of some inefficient queries
What does this PR do?
improves the queries for discipline dashboard data to speed up load time
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?