New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Fix bug with rendering IepDialog in Bedford #2376

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 28, 2019

Who is this PR for?

Bedford educators

What problem does this PR fix?

#2359 introduced a regression to the profile page for Bedford only. This led to the profile page not loading, and Rollbar errors were ambiguous (which would be improved with React 16 error boundaries), so I mistakenly thought this was related to trying to interact after session expiration.

What does this PR do?

Fixes the bug; wraps the return value from <IepDialog /> in an element rather than a plain string (https://reactjs.org/docs/error-decoder.html/?invariant=109&args[]=t) and renames it to <IepDialogLink /> to clarify and add tests and stories.

Checklists

Which features or pages does this PR touch?

  • Student Profile
  • Reading entry
  • Reading grouping

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 28, 2019

selfie

@kevinrobinson kevinrobinson merged commit 7d701e4 into master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/bedford-iep-dialog branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment