Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
SessionRenewal: Rework to probe server to warn about session expiration instead of using heuristic #2377
Who is this PR for?
What problem does this PR fix?
There were some user reports of being signed out unexpectedly, and in investigating and in looking at Rollbar errors related to
What does this PR do?
This works better than the previous approach because it avoids UI-side heuristics, and just checks with the server. If the session has already expired, the UI redirects to close the page, since any data from interactions would be lost anyway. The expiration message should make it clear to users this would happen beforehand, and this PR changes the background color to a warning orange instead of blue.
This revises the Rollbar instrumentation and keeps it in place, so we can verify this is working as expected.
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?