New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Add Q2 self-reflection to profile notes #2381

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 29, 2019

Who is this PR for?

SHS educators, students

What does this PR do?

Imports Q2 self-reflection survey and makes it visible in student profile notes. Also factors out GenericSurveyProcessor and uses it for this and for the mid-year survey.

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 29, 2019

Verified this manually again too, looks 👍

@kevinrobinson kevinrobinson merged commit e3b8cdf into master Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the patch/mid-year-importer branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment