New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student voice: Highlight new student voice surveys in home feed #2382

Merged
merged 8 commits into from Jan 29, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

kevinrobinson commented Jan 29, 2019

Who is this PR for?

SHS educators, students

What problem does this PR fix?

When students share their perspectives in mid-year surveys or Q2 self-reflections, these are visible as notes in their profile pages (eg #2381 and #2379). But educators can't see that this is happening without going and looking for it.

What does this PR do?

Adds cards into the home feed about new student voice surveys, with links to profiles. Also update display on profile notes list, to clarify this is the student's voice and not from an educator (educator value was placeholder previously).

This is behind and ENV feature switch.

Screenshot (if adding a client-side feature)

example

screen shot 2019-01-29 at 12 06 54 pm

click to expand when many students

screen shot 2019-01-29 at 1 38 33 pm

permutations, with sampling different students to highlight on each component mounting

screen shot 2019-01-29 at 1 38 28 pm

updates notes list

screen shot 2019-01-29 at 2 22 28 pm

Checklists

Which features or pages does this PR touch?

  • Home page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Jan 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit e17e68d into master Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/home-feed-student-voice-cards branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment