Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upStudent voice: Add profile insights from winter student voice surveys #2383
Conversation
kevinrobinson
added some commits
Jan 29, 2019
kevinrobinson
referenced this pull request
Jan 29, 2019
Merged
Student voice: Add self-reflection on Q2 next to grades #2384
kevinrobinson
added some commits
Jan 29, 2019
kevinrobinson
force-pushed the
feature/winter-insights
branch
from
1590df3
to
4b4adf8
Jan 29, 2019
kevinrobinson
merged commit 2b46174
into
master
Jan 29, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
kevinrobinson
deleted the
feature/winter-insights
branch
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
selfie |
kevinrobinson
referenced this pull request
Jan 30, 2019
Merged
Student voice: Fix timezone bug on imports; release profile insights with feature switch for Q2 self-reflection #2387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kevinrobinson commentedJan 29, 2019
Who is this PR for?
SHS educators, students
What problem does this PR fix?
Students have shared updates on what they want their teachers to know, and insights from their Q2 self-reflection, but these will become less visible over time.
What does this PR do?
Builds on #2382, and updates the student profile to show these insights (and replaces fall student surveys if there are any).
For now, shipped behind browser-side query param switch.
Screenshot (if adding a client-side feature)
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?